HomePhabricator

Merge #16918: test: Make PORT_MIN in test runner configurable

Description

Merge #16918: test: Make PORT_MIN in test runner configurable

Summary:
fa69588537bc91c0aedbc89ef1760d89cbffad75 test: Make PORT_MIN in test runner configurable (MarcoFalke)

Pull request description:

This is needed when some ports in the port range are used by other processes. Note that simply assigning the ports dynamically does not work:

* We spin up several nodes per test (each node gets its own port)
* We run several tests in parallel

So to avoid nodes from different tests colliding on ports, the port assignment must be deterministic (can not be dynamic).

Fixes: #10869

ACKs for top commit:

practicalswift:
  ACK fa69588537bc91c0aedbc89ef1760d89cbffad75 -- diff looks correct
promag:
  ACK fa69588537bc91c0aedbc89ef1760d89cbffad75.

Tree-SHA512: e79adb015e7de79064e2d14336c38bc9672bd779ad6c52917721897e73f617c39d32c068a369c26670002a6c4ab95a71ef3a6878ebdd9710e02f410e2f7bcd14

Backport of Core PR16918

Test Plan: ninja check-functional

Reviewers: #bitcoin_abc, nakihito

Reviewed By: nakihito

Subscribers: nakihito

Differential Revision: https://reviews.bitcoinabc.org/D6075

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Sep 22 2019, 14:14
jasonbcoxCommitted on May 14 2020, 19:51
jasonbcoxPushed on May 14 2020, 19:51
Reviewer
nakihito
Differential Revision
D6075: Merge #16918: test: Make PORT_MIN in test runner configurable
Parents
rABC76d513094857: Remove Core release note file, update previous release notes, and fix generate…
Branches
Unknown
Tags
Unknown