HomePhabricator

refactor: Remove chainparams arg from CChainState member functions

Description

refactor: Remove chainparams arg from CChainState member functions

Summary:
Passing this is confusing and redundant with the m_params member.
This is a backport of core#21789 [2/2]
https://github.com/bitcoin/bitcoin/pull/21789/commits/fa0d9211ef87a682573aaae932c0c440acbcb8a8

Depends on D12189

The result is not quite as spectacular as in the source material, as for many of these methods the Bitcoin ABC codebases does not pass directly a CChainParams object but rather a Config object. I will attempt to do the same operation for Config in a separate diff.

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12190

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Apr 27 2021, 20:54
PiRKCommitted on Oct 11 2022, 07:12
PiRKPushed on Oct 11 2022, 07:12
Reviewer
Restricted Project
Differential Revision
D12190: refactor: Remove chainparams arg from CChainState member functions
Parents
rABCc66651a15367: refactor: Remove ::Params() global from inside CChainState member functions
Branches
Unknown
Tags
Unknown