refactor: Remove ::Params() global from inside CChainState member functions
ClosedPublic
Actions

Authored by PiRK on Oct 10 2022, 13:58.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc66651a15367: refactor: Remove ::Params() global from inside CChainState member functions

Summary

It is confusing and verbose to repeatedly access the global when a
member variable can simply refer to it.

This is a backport of core#21789 [1/2]
https://github.com/bitcoin/bitcoin/pull/21789/commits/fa389471251f043ec25e7b01e59b37d3b921ce54

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 10 2022, 13:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2022, 13:58

PiRK requested review of this revision.Oct 10 2022, 13:58

teamcity edited the summary of this revision. (Show Details)Oct 10 2022, 13:58

PiRK added a child revision: D12190: refactor: Remove chainparams arg from CChainState member functions.Oct 10 2022, 14:01

PiRK mentioned this in D12191: refactor: make Config a CChainstate member variable.Oct 10 2022, 14:10

Harbormaster completed remote builds in B20422: Diff 35556.Oct 10 2022, 14:15

Fabien accepted this revision.Oct 10 2022, 14:48

This revision is now accepted and ready to land.Oct 10 2022, 14:48

Closed by commit rABCc66651a15367: refactor: Remove ::Params() global from inside CChainState member functions (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyOct 11 2022, 07:12

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc66651a15367: refactor: Remove ::Params() global from inside CChainState member functions.

PiRK mentioned this in D12198: refactor: remove more unused config argument.Oct 11 2022, 08:19

Revision Contents
Changeset List

Path

Size

src/

validation.h

2 lines

validation.cpp

14 lines

Diff 35569

View Options

src/validation.h