refactor: make Config a CChainstate member variable
AbandonedPublic
Actions

Authored by PiRK on Oct 10 2022, 14:10.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

It is used in 9 different CChainstate methods, so it makes sense to include it in the class, like we did for Params in D12189

Depends on D12190

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20424
Build 40521: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40520: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 10 2022, 14:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2022, 14:10

PiRK requested review of this revision.Oct 10 2022, 14:10

PiRK added a child revision: D12192: refactor: Remove config arg from CChainState member functions.Oct 10 2022, 14:14

Harbormaster completed remote builds in B20424: Diff 35558.Oct 10 2022, 14:28

Fabien requested changes to this revision.Oct 10 2022, 14:50

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/validation.h
838	CChainParams is already a member of Config

This revision now requires changes to proceed.Oct 10 2022, 14:50

PiRK abandoned this revision.Oct 12 2022, 10:42

Revision Contents
Changeset List

Path

Size

src/

validation.h

1 line

validation.cpp

5 lines

Diff 35558

View Options

src/validation.h