HomePhabricator

[CMAKE] Refactor warnings for secp256k1

Authored by Fabien on Aug 5 2019, 07:40.

Description

[CMAKE] Refactor warnings for secp256k1

Summary:
The -Wshadow warning is duplicated from the top level CMakeLists.txt
and can therefore be removed.
The -Wno-nonnull is not useful as it actually doesn't remove any
warning. This also makes it more consistent with autotools build which
doesn't enforce this warning suppression.

Test Plan:
The warnings should be the same before and after this patch:

ninja check

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D3798

Details

Committed
FabienAug 6 2019, 09:02
Pushed
FabienAug 6 2019, 09:02
Reviewer
Restricted Project
Differential Revision
D3798: [CMAKE] Refactor warnings for secp256k1
Parents
rABC4e4266cec73d: Add a message to static_assert
Branches
Unknown
Tags
Unknown