Page MenuHomePhabricator

[CMAKE] Refactor warnings for secp256k1

Authored by Fabien on Aug 5 2019, 08:03.



The -Wshadow warning is duplicated from the top level CMakeLists.txt
and can therefore be removed.
The -Wno-nonnull is not useful as it actually doesn't remove any
warning. This also makes it more consistent with autotools build which
doesn't enforce this warning suppression.

Test Plan

The warnings should be the same before and after this patch:

ninja check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Aug 5 2019, 08:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2019, 08:03
jasonbcox accepted this revision.Aug 5 2019, 22:11
This revision is now accepted and ready to land.Aug 5 2019, 22:11
This revision was automatically updated to reflect the committed changes.

This breaks the set of warning when building standalone.