Page MenuHomePhabricator

[CMAKE] Refactor warnings for secp256k1
ClosedPublic

Authored by Fabien on Mon, Aug 5, 08:03.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC5b54505f2c1c: [CMAKE] Refactor warnings for secp256k1
Summary

The -Wshadow warning is duplicated from the top level CMakeLists.txt
and can therefore be removed.
The -Wno-nonnull is not useful as it actually doesn't remove any
warning. This also makes it more consistent with autotools build which
doesn't enforce this warning suppression.

Test Plan

The warnings should be the same before and after this patch:

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Aug 5, 08:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Aug 5, 08:03
jasonbcox accepted this revision.Mon, Aug 5, 22:11
This revision is now accepted and ready to land.Mon, Aug 5, 22:11
This revision was automatically updated to reflect the committed changes.

This breaks the set of warning when building standalone.