Page MenuHomePhabricator
Differential D3798

[CMAKE] Refactor warnings for secp256k1
ClosedPublic
Actions

Authored by Fabien on Aug 5 2019, 08:03.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING5b54505f2c1c: [CMAKE] Refactor warnings for secp256k1
rABC5b54505f2c1c: [CMAKE] Refactor warnings for secp256k1
Summary

The -Wshadow warning is duplicated from the top level CMakeLists.txt
and can therefore be removed.
The -Wno-nonnull is not useful as it actually doesn't remove any
warning. This also makes it more consistent with autotools build which
doesn't enforce this warning suppression.

Test Plan

The warnings should be the same before and after this patch:

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_secp256k1_duplicated_warnings
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7039
Build 12125: Bitcoin ABC Buildbot (legacy)
Build 12124: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 5 2019, 08:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2019, 08:03
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 5 2019, 08:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 5 2019, 08:15

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7039: Diff 10605.Aug 5 2019, 08:15
jasonbcox accepted this revision.Aug 5 2019, 22:11
This revision is now accepted and ready to land.Aug 5 2019, 22:11
Closed by commit rABC5b54505f2c1c: [CMAKE] Refactor warnings for secp256k1 (authored by Fabien). · Explain WhyAug 6 2019, 09:02
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC5b54505f2c1c: [CMAKE] Refactor warnings for secp256k1.
Fabien mentioned this in D3786: [CMAKE] Make warnings the same with cmake and autotools.Aug 6 2019, 09:20
deadalnix added a comment.Aug 6 2019, 16:47

This breaks the set of warning when building standalone.

Fabien added a commit: rSTAGING5b54505f2c1c: [CMAKE] Refactor warnings for secp256k1.Sep 19 2019, 01:39

Revision Contents
Changeset List

PathSize
src/
secp256k1/
2 lines

Diff 10605

View Options

src/secp256k1/CMakeLists.txt

Loading...