Page MenuHomePhabricator

[CMAKE] Refactor warnings for secp256k1
ClosedPublic

Authored by Fabien on Aug 5 2019, 08:03.

Details

Summary

The -Wshadow warning is duplicated from the top level CMakeLists.txt
and can therefore be removed.
The -Wno-nonnull is not useful as it actually doesn't remove any
warning. This also makes it more consistent with autotools build which
doesn't enforce this warning suppression.

Test Plan

The warnings should be the same before and after this patch:

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_secp256k1_duplicated_warnings
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7039
Build 12125: Bitcoin ABC Buildbot (legacy)
Build 12124: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 5 2019, 22:11
This revision was automatically updated to reflect the committed changes.

This breaks the set of warning when building standalone.