HomePhabricator

httpserver: use own HTTP status codes

Description

httpserver: use own HTTP status codes

Summary:
Before, macros defined in <event2/http.h> have been used
for some HTTP status codes.
<event2/http.h> is included implicitly and the usage
of its status code macros is inconsistent with the majority
HTTP response implementations in this file.

Now, the HTTPStatusCode enum from <rpc/protocol.h> is
consistently used for all HTTP response implementations.

This is a backport of Core PR18168

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8779

Details

Provenance
Filip Gospodinov <f@gospodinov.ch>Authored on Jan 5 2021, 09:36
PiRKCommitted on Jan 5 2021, 09:36
abc-botPushed on Jan 5 2021, 09:41
Reviewer
Restricted Project
Differential Revision
D8779: httpserver: use own HTTP status codes
Parents
rABCebee9bbf3ea9: Merge #12218: net: Move misbehaving logging to net logging category
Branches
Unknown
Tags
Unknown