HomePhabricator

Merge #12218: net: Move misbehaving logging to net logging category

Description

Merge #12218: net: Move misbehaving logging to net logging category

Summary:
d3a185a net: Move misbehaving logging to net logging category (Wladimir J. van der Laan)

Pull request description:

This moves the error messages for misbehavior (when available) into the line that reports the misbehavior, as well as moves the logging to the `net` category.

This is a continuation of #11583 and avoids serious-looking errors due to misbehaving peers. As it is impossible to correlate the `peer=X` numbers to specific incoming connections now without enabling the `net` category, it doesn't really help to see these messages by default.

To do this, Misbehaving() gains an optional `message` argument.

E.g. change:

    2018-01-18 16:02:27 Misbehaving: x.x.x.x:62174 peer=164603 (80 -> 100) BAN THRESHOLD EXCEEDED
    2018-01-18 16:02:27 ERROR: non-continuous headers sequence

to

    2018-01-18 16:02:27 Misbehaving: x.x.x.x:62174 peer=164603 (80 -> 100) BAN THRESHOLD EXCEEDED: non-continuous headers sequence

When there is a category for "important" net messages (see #12219 ), we should move it there.

Tree-SHA512: 51c97e9a649bf5409f2fd4625fa1243a036e9c9de6037bb064244207408c2e0eb025e3af80866df673cdc006b8f35dc4078d074033f0d4c6a73bbb03949a269f

Backport of Core PR12218
https://github.com/bitcoin/bitcoin/pull/12218/files

Test Plan:

make check
test_runner.py

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4150

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Jan 5 2021, 08:37
FabienCommitted on Jan 5 2021, 08:37
abc-botPushed on Jan 5 2021, 08:43
Reviewer
Restricted Project
Differential Revision
D4150: Merge #12218: net: Move misbehaving logging to net logging category
Parents
rABC29626634c972: refactor: test/bench: dedup SetupDummyInputs()
Branches
Unknown
Tags
Unknown