HomePhabricator

validation: remove redundant check on pindex

Description

validation: remove redundant check on pindex

Summary:
This removes a conditional that checks if pindex is equal to nullptr.
This check is redundant because the branch where pindex is set returns at an earlier time. Additionaly, The independence of the earlier and later pindex is made clearer.

This is a backport of core#20868

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11772

Details

Provenance
PiRKAuthored on Jul 20 2022, 09:32
PiRKPushed on Jul 21 2022, 07:39
Reviewer
Restricted Project
Differential Revision
D11772: validation: remove redundant check on pindex
Parents
rABC9b904d85f5a3: locks and docs in ATMP and CheckInputsFromMempoolAndCache
Branches
Unknown
Tags
Unknown