HomePhabricator

Add metavar to match var name in help text + Change wording for better…

Description

Add metavar to match var name in help text + Change wording for better readability

Summary:

The help text given by test/functional/test_runner.py -h refers to the value n, which is defined as COMBINEDLOGSLEN in the list of commands.

To make the help text consistent, this PR changes the display name COMBINEDLOGSLEN to n by setting the argparse metavar attribute. (metavar only changes the displayed name)

This is a backport of Core PR14619

Test Plan:

$ test/functional/test_runner.py -h | grep -A 3 combinedlogslen
  --combinedlogslen n, -c n
                        On failure, print a log (of length n lines) to the
                        console, combined from the test framework and all test
                        nodes. (default: 0)

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8347

Details

Provenance
Martin Erlandsson <merland@users.noreply.github.com>Authored on Oct 31 2018, 13:39
PiRKCommitted on Nov 10 2020, 09:50
PiRKPushed on Nov 10 2020, 09:50
Reviewer
Restricted Project
Differential Revision
D8347: Add metavar to match var name in help text + Change wording for better readability
Parents
rABC4af6f8885cc2: Pass export privkey DER compression flag correctly
Branches
Unknown
Tags
Unknown