HomePhabricator
Diffusion Bitcoin ABC 6387a72b3611

Merge #13188: qa: Remove unused option --srcdir
6387a72b3611
Actions

Description

Merge #13188: qa: Remove unused option --srcdir

Summary:
fac1e1f qa: Remove unused option --srcdir (MarcoFalke)

Pull request description:

The `srcdir` option was both unused and misleading; It should have been called `builddir`. So remove it.

Tree-SHA512: 2c24dcf2aa82219158b8cbbf03dd3f0f51f805f1f5f670faa1fd59e5a8d60fda120ffddadeccb058d8d3f20583b4952be7afd2df6bbefb9367d35c0f0a9fda3c

Backport of Core PR13188
https://github.com/bitcoin/bitcoin/pull/13188/

Test Plan:

make check
test_runner.py

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3867

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on May 9 2018, 08:41
nakihitoCommitted on Aug 14 2019, 17:45
nakihitoPushed on Aug 14 2019, 17:45
Reviewer
Restricted Owners Package
Differential Revision
D3867: Merge #13188: qa: Remove unused option --srcdir
Parents
rABCea63c14f0d04: qa: Read reject reasons from debug log, not p2p messages
Branches
Unknown
Tags
Unknown

Event Timeline

Nico Guiton <nico@bitframe.org> committed rABC6387a72b3611: Merge #13188: qa: Remove unused option --srcdir (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Aug 14 2019, 17:45
Nico Guiton <nico@bitframe.org> added an edge: D3867: Merge #13188: qa: Remove unused option --srcdir.

Changes (2)

PathSize
test/
functional/
test_framework/

rABC6387a72b3611

View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_runner.py

Loading...