Merge #13188: qa: Remove unused option --srcdir
ClosedPublic
Actions

Authored by nakihito on Aug 13 2019, 23:40.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING6387a72b3611: Merge #13188: qa: Remove unused option --srcdir
rABC6387a72b3611: Merge #13188: qa: Remove unused option --srcdir

Summary

fac1e1f qa: Remove unused option --srcdir (MarcoFalke)

Pull request description:

The `srcdir` option was both unused and misleading; It should have been called `builddir`. So remove it.

Tree-SHA512: 2c24dcf2aa82219158b8cbbf03dd3f0f51f805f1f5f670faa1fd59e5a8d60fda120ffddadeccb058d8d3f20583b4952be7afd2df6bbefb9367d35c0f0a9fda3c

Backport of Core PR13188
https://github.com/bitcoin/bitcoin/pull/13188/

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Aug 13 2019, 23:40

Owners added a reviewer: Restricted Owners Package.Aug 13 2019, 23:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 13 2019, 23:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7137: Diff 10774.Aug 13 2019, 23:46

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Aug 14 2019, 04:58

This revision is now accepted and ready to land.Aug 14 2019, 04:58

Closed by commit rABC6387a72b3611: Merge #13188: qa: Remove unused option --srcdir (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 14 2019, 17:45

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC6387a72b3611: Merge #13188: qa: Remove unused option --srcdir.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING6387a72b3611: Merge #13188: qa: Remove unused option --srcdir.Sep 19 2019, 01:49

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_framework.py

10 lines

test_runner.py

3 lines

Diff 10788

View Options

test/functional/test_framework/test_framework.py