Page MenuHomePhabricator

Merge #13188: qa: Remove unused option --srcdir
ClosedPublic

Authored by nakihito on Tue, Aug 13, 23:40.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC6387a72b3611: Merge #13188: qa: Remove unused option --srcdir
Summary

fac1e1f qa: Remove unused option --srcdir (MarcoFalke)

Pull request description:

The `srcdir` option was both unused and misleading; It should have been called `builddir`. So remove it.

Tree-SHA512: 2c24dcf2aa82219158b8cbbf03dd3f0f51f805f1f5f670faa1fd59e5a8d60fda120ffddadeccb058d8d3f20583b4952be7afd2df6bbefb9367d35c0f0a9fda3c

Backport of Core PR13188
https://github.com/bitcoin/bitcoin/pull/13188/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Tue, Aug 13, 23:40
Owners added a reviewer: Restricted Owners Package.Tue, Aug 13, 23:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Aug 13, 23:40
deadalnix accepted this revision.Wed, Aug 14, 04:58
This revision is now accepted and ready to land.Wed, Aug 14, 04:58