HomePhabricator

Merge #12436: [rpc] Adds a functional test to validate the transaction version…

Authored by Wladimir J. van der Laan <laanwj@gmail.com> on Apr 24 2018, 09:56.

Description

Merge #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output

Summary:
09b30db Asserts that the tx version number is a signed 32-bit integer. (251)

Pull request description:

This PR attempts to resolve #11561 by addressing the feedback from @MarcoFalke; and @gmaxwell in #12430.

Commit 30e9d24 adds a functional test to `rpc_rawtransaction.py` to assert that the transaction version number in the RPC output is a signed 32-bit integer.

The functional test uses the raw transaction data from Mainnet transaction `c659729a7fea5071361c2c1a68551ca2bf77679b27086cc415adeeb03852e369`.

Tree-SHA512: d78f3120b9aa04537561ab5584769a838b25e162c5caa6e1543256fb27538aa4c708c939fb5ba93ccb3fa676c2d92ce8eb9cc78869f80ac96be64a7bec7bebd0

Backport of Core PR12436
https://github.com/bitcoin/bitcoin/pull/12436/

Test Plan:

make check
test_runner.py

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3866

Details

Committed
nakihitoAug 13 2019, 22:24
Pushed
nakihitoAug 13 2019, 22:24
Reviewer
Restricted Owners Package
Differential Revision
D3866: Merge #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output
Parents
rABC65afda20a75a: Merge #14024: qa: Add TestNode::assert_debug_log
Branches
Unknown
Tags
Unknown