Page MenuHomePhabricator

Merge #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output
ClosedPublic

Authored by nakihito on Tue, Aug 13, 18:52.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCd2b5b9643921: Merge #12436: [rpc] Adds a functional test to validate the transaction version…
Summary

09b30db Asserts that the tx version number is a signed 32-bit integer. (251)

Pull request description:

This PR attempts to resolve #11561 by addressing the feedback from @MarcoFalke; and @gmaxwell in #12430.

Commit 30e9d24 adds a functional test to `rpc_rawtransaction.py` to assert that the transaction version number in the RPC output is a signed 32-bit integer.

The functional test uses the raw transaction data from Mainnet transaction `c659729a7fea5071361c2c1a68551ca2bf77679b27086cc415adeeb03852e369`.

Tree-SHA512: d78f3120b9aa04537561ab5584769a838b25e162c5caa6e1543256fb27538aa4c708c939fb5ba93ccb3fa676c2d92ce8eb9cc78869f80ac96be64a7bec7bebd0

Backport of Core PR12436
https://github.com/bitcoin/bitcoin/pull/12436/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Tue, Aug 13, 18:52
Owners added a reviewer: Restricted Owners Package.Tue, Aug 13, 18:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Aug 13, 18:52
jasonbcox accepted this revision.Tue, Aug 13, 21:36
This revision is now accepted and ready to land.Tue, Aug 13, 21:36