Page MenuHomePhabricator
Differential D3866

Merge #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output
ClosedPublic
Actions

Authored by nakihito on Aug 13 2019, 18:52.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGd2b5b9643921: Merge #12436: [rpc] Adds a functional test to validate the transaction version…
rABCd2b5b9643921: Merge #12436: [rpc] Adds a functional test to validate the transaction version…
Summary

09b30db Asserts that the tx version number is a signed 32-bit integer. (251)

Pull request description:

This PR attempts to resolve #11561 by addressing the feedback from @MarcoFalke; and @gmaxwell in #12430.

Commit 30e9d24 adds a functional test to `rpc_rawtransaction.py` to assert that the transaction version number in the RPC output is a signed 32-bit integer.

The functional test uses the raw transaction data from Mainnet transaction `c659729a7fea5071361c2c1a68551ca2bf77679b27086cc415adeeb03852e369`.

Tree-SHA512: d78f3120b9aa04537561ab5584769a838b25e162c5caa6e1543256fb27538aa4c708c939fb5ba93ccb3fa676c2d92ce8eb9cc78869f80ac96be64a7bec7bebd0

Backport of Core PR12436
https://github.com/bitcoin/bitcoin/pull/12436/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Aug 13 2019, 18:52
Owners added a reviewer: Restricted Owners Package.Aug 13 2019, 18:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 13 2019, 18:52
teamcity added a comment.Aug 13 2019, 18:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 13 2019, 18:57

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7135: Diff 10768!Aug 13 2019, 18:57
teamcity added a comment.Aug 13 2019, 18:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 13 2019, 19:01

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 13 2019, 19:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Aug 13 2019, 21:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox accepted this revision.Aug 13 2019, 21:36
This revision is now accepted and ready to land.Aug 13 2019, 21:36
teamcity added a comment.Aug 13 2019, 21:39

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7135: Diff 10768.Aug 13 2019, 21:39
Closed by commit rABCd2b5b9643921: Merge #12436: [rpc] Adds a functional test to validate the transaction version… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 13 2019, 22:24
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCd2b5b9643921: Merge #12436: [rpc] Adds a functional test to validate the transaction version….
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGd2b5b9643921: Merge #12436: [rpc] Adds a functional test to validate the transaction version….Sep 19 2019, 01:49

Revision Contents
Changeset List

PathSize
test/
functional/
22 lines

Diff 10773

View Options

test/functional/rpc_rawtransaction.py

Loading...