HomePhabricator

[net] Remove asmap argument from CNode::CopyStats()

Description

[net] Remove asmap argument from CNode::CopyStats()

Summary:
This saves passing around a reference to the asmap std::vector<bool>.

This is a backport of core#22911 [4/4]
https://github.com/bitcoin/bitcoin/pull/22911/commits/853c4edb70f897a6a7165abaea4a303d7d448721

Depends on D10781

Test Plan:
ninja all check-all

Compile and run the fuzzer:

cmake -GNinja .. -DCMAKE_C_COMPILER=$AFLPATH/afl-clang -DCMAKE_CXX_COMPILER=$AFLPATH/afl-clang++
ninja bitcoin-fuzzers
AFL_I_DONT_CARE_ABOUT_MISSING_CRASHES=1 AFL_SKIP_CPUFREQ=1 ${AFLPATH}/afl-fuzz -i ${DIR_FUZZ_IN}/net -o ${AFLOUT}/net -m250 -- src/test/fuzz/net

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10782

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Sep 1 2021, 10:24
PiRKCommitted on Jan 10 2022, 13:57
PiRKPushed on Jan 10 2022, 13:57
Reviewer
Restricted Project
Differential Revision
D10782: [net] Remove asmap argument from CNode::CopyStats()
Parents
rABC67888e5150d2: [asmap] Make DecodeAsmap() a utility function
Branches
Unknown
Tags
Unknown