Paths

Table of Contentst

Differential D10782

[net] Remove asmap argument from CNode::CopyStats()
ClosedPublic
Actions

Authored by PiRK on Jan 7 2022, 10:05.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC682cf70170d1: [net] Remove asmap argument from CNode::CopyStats()

Summary

This saves passing around a reference to the asmap std::vector<bool>.

This is a backport of core#22911 [4/4]
https://github.com/bitcoin/bitcoin/pull/22911/commits/853c4edb70f897a6a7165abaea4a303d7d448721

Depends on D10781

Test Plan

ninja all check-all

Compile and run the fuzzer:

cmake -GNinja .. -DCMAKE_C_COMPILER=$AFLPATH/afl-clang -DCMAKE_CXX_COMPILER=$AFLPATH/afl-clang++
ninja bitcoin-fuzzers
AFL_I_DONT_CARE_ABOUT_MISSING_CRASHES=1 AFL_SKIP_CPUFREQ=1 ${AFLPATH}/afl-fuzz -i ${DIR_FUZZ_IN}/net -o ${AFLOUT}/net -m250 -- src/test/fuzz/net

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 7 2022, 10:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2022, 10:05

PiRK requested review of this revision.Jan 7 2022, 10:05

teamcity edited the summary of this revision. (Show Details)Jan 7 2022, 10:06

Harbormaster completed remote builds in B17821: Diff 31681.Jan 7 2022, 10:42

Please build and run the fuzzer as part of your test plan

This revision now requires changes to proceed.Jan 7 2022, 11:11

Compile and run fuzzers as part of the test plan

Fabien accepted this revision.Jan 10 2022, 09:49

This revision is now accepted and ready to land.Jan 10 2022, 09:49

Closed by commit rABC682cf70170d1: [net] Remove asmap argument from CNode::CopyStats() (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyJan 10 2022, 13:57

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC682cf70170d1: [net] Remove asmap argument from CNode::CopyStats().

Revision Contents
Changeset List

Path

Size

src/

2 lines

6 lines

test/

fuzz/

8 lines

Diff 31726

src/net.h

Loading...

src/net.cpp

Loading...

src/test/fuzz/net.cpp

Loading...