Page MenuHomePhabricator
Differential D10799

convert unsafe fs::path std::string conversion calls [5/7] (util)
ClosedPublic
Actions

Authored by PiRK on Jan 10 2022, 13:01.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe5645bc7fa26: convert unsafe fs::path std::string conversion calls [5/7] (util)
Summary

This is a partial backport of core#22937 [2e/2g]
https://github.com/bitcoin/bitcoin/pull/22937/commits/6544ea5035268025207d2402db2f7d90fde947a6

The backport for this commit was split in to multiple commits to make review easier. This part deals with converting fs::string() calls that
will become unsafe when migrating from boost::filesystem to std::filesystem.

Depends on D10798

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 10 2022, 13:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2022, 13:01
PiRK requested review of this revision.Jan 10 2022, 13:01
teamcity edited the summary of this revision. (Show Details)Jan 10 2022, 13:01
PiRK added a child revision: D10800: convert unsafe fs::path std::string conversion calls [6/7] (wallet).Jan 10 2022, 13:03
Harbormaster completed remote builds in B17855: Diff 31718.Jan 10 2022, 13:30
PiRK retitled this revision from convert unsafe fs::path std::string conversion calls [5/7] to convert unsafe fs::path std::string conversion calls [5/7] (util).Jan 10 2022, 15:12
PiRK edited the summary of this revision. (Show Details)
Fabien accepted this revision.Jan 11 2022, 09:52
This revision is now accepted and ready to land.Jan 11 2022, 09:52
Closed by commit rABCe5645bc7fa26: convert unsafe fs::path std::string conversion calls [5/7] (util) (authored by PiRK). · Explain WhyJan 11 2022, 12:27
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe5645bc7fa26: convert unsafe fs::path std::string conversion calls [5/7] (util).

Revision Contents
Changeset List

PathSize
src/
util/
6 lines
16 lines
38 lines

Diff 31758

View Options

src/util/asmap.cpp

Loading...
View Options

src/util/settings.cpp

Loading...
View Options

src/util/system.cpp

Loading...