Page MenuHomePhabricator
Differential D10783

error if settings.json exists, but is unreadable
ClosedPublic
Actions

Authored by PiRK on Jan 7 2022, 10:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCddb02862f86c: error if settings.json exists, but is unreadable
Summary

This is a backport of core#22591

Test Plan

ninja all check-all

$ sudo chmod a-rwx /bitcoinddata/settings.json
$ src/bitcoind
Error: Failed loading settings file:
- /bitcoinddata/settings.json. Please check permissions.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 7 2022, 10:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2022, 10:06
PiRK requested review of this revision.Jan 7 2022, 10:06
teamcity edited the summary of this revision. (Show Details)Jan 7 2022, 10:07
PiRK added a child revision: D10785: refactor: Block unsafe fs::path std::string conversion calls.Jan 7 2022, 10:13
Harbormaster completed remote builds in B17822: Diff 31682.Jan 7 2022, 10:50
Fabien requested changes to this revision.Jan 7 2022, 11:13
Fabien added a subscriber: Fabien.

Is there a test for that ?

This revision now requires changes to proceed.Jan 7 2022, 11:13
PiRK requested review of this revision.Jan 7 2022, 15:03
PiRK edited the test plan for this revision. (Show Details)

updated test plan

Fabien accepted this revision.Jan 7 2022, 15:12
This revision is now accepted and ready to land.Jan 7 2022, 15:12
PiRK updated this revision to Diff 31696.Jan 7 2022, 15:21
PiRK edited the test plan for this revision. (Show Details)

add a functional test

Harbormaster completed remote builds in B17835: Diff 31696.Jan 7 2022, 15:33
teamcity added a comment.Jan 7 2022, 15:33
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_settings.py ======

------- Stdout: -------
2022-01-07T15:33:03.930000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220107_153139/feature_settings_86
2022-01-07T15:33:06.940000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 620, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 301, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_settings.py", line 99, in run_test
    match=ErrorMatch.PARTIAL_REGEX)
  File "/work/test/functional/test_framework/test_node.py", line 635, in assert_start_raises_init_error
    'Expected message "{}" does not partially match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 207, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Please check permissions." does not partially match stderr:
"Error: Failed loading settings file:
- Found duplicate key key in settings file /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220107_153139/feature_settings_86/node0/regtest/settings.json"
2022-01-07T15:33:06.991000Z TestFramework (INFO): Stopping nodes
2022-01-07T15:33:06.991000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220107_153139/feature_settings_86
2022-01-07T15:33:06.991000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220107_153139/feature_settings_86/test_framework.log
2022-01-07T15:33:06.991000Z TestFramework (ERROR): 
2022-01-07T15:33:06.991000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220107_153139/feature_settings_86' to consolidate all logs
2022-01-07T15:33:06.991000Z TestFramework (ERROR): 
2022-01-07T15:33:06.991000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-07T15:33:06.991000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-07T15:33:06.991000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_settings.py

teamcity added a comment.Jan 7 2022, 15:35
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_settings.py ======

------- Stdout: -------
2022-01-07T15:33:56.348000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220107_152922/feature_settings_86
2022-01-07T15:34:00.488000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 620, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 301, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_settings.py", line 99, in run_test
    match=ErrorMatch.PARTIAL_REGEX)
  File "/work/test/functional/test_framework/test_node.py", line 635, in assert_start_raises_init_error
    'Expected message "{}" does not partially match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 207, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Please check permissions." does not partially match stderr:
"Error: Failed loading settings file:
- Found duplicate key key in settings file /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220107_152922/feature_settings_86/node0/regtest/settings.json"
2022-01-07T15:34:00.539000Z TestFramework (INFO): Stopping nodes
2022-01-07T15:34:00.539000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220107_152922/feature_settings_86
2022-01-07T15:34:00.539000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220107_152922/feature_settings_86/test_framework.log
2022-01-07T15:34:00.539000Z TestFramework (ERROR): 
2022-01-07T15:34:00.539000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220107_152922/feature_settings_86' to consolidate all logs
2022-01-07T15:34:00.539000Z TestFramework (ERROR): 
2022-01-07T15:34:00.540000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-07T15:34:00.540000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-07T15:34:00.540000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_settings.py

teamcity added a comment.Jan 7 2022, 15:39
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_settings.py ======

------- Stdout: -------
2022-01-07T15:34:38.906000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_153112/feature_settings_86
2022-01-07T15:34:41.939000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 620, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 301, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_settings.py", line 99, in run_test
    match=ErrorMatch.PARTIAL_REGEX)
  File "/work/test/functional/test_framework/test_node.py", line 635, in assert_start_raises_init_error
    'Expected message "{}" does not partially match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 207, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Please check permissions." does not partially match stderr:
"Error: Failed loading settings file:
- Found duplicate key key in settings file /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_153112/feature_settings_86/node0/regtest/settings.json"
2022-01-07T15:34:41.990000Z TestFramework (INFO): Stopping nodes
2022-01-07T15:34:41.990000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_153112/feature_settings_86
2022-01-07T15:34:41.990000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_153112/feature_settings_86/test_framework.log
2022-01-07T15:34:41.990000Z TestFramework (ERROR): 
2022-01-07T15:34:41.990000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_153112/feature_settings_86' to consolidate all logs
2022-01-07T15:34:41.990000Z TestFramework (ERROR): 
2022-01-07T15:34:41.990000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-07T15:34:41.990000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-07T15:34:41.990000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: feature_settings.py ======

------- Stdout: -------
2022-01-07T15:38:26.220000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_153523/feature_settings_86
2022-01-07T15:38:29.053000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 620, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 301, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_settings.py", line 99, in run_test
    match=ErrorMatch.PARTIAL_REGEX)
  File "/work/test/functional/test_framework/test_node.py", line 635, in assert_start_raises_init_error
    'Expected message "{}" does not partially match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 207, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Please check permissions." does not partially match stderr:
"Error: Failed loading settings file:
- Found duplicate key key in settings file /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_153523/feature_settings_86/node0/regtest/settings.json"
2022-01-07T15:38:29.104000Z TestFramework (INFO): Stopping nodes
2022-01-07T15:38:29.105000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_153523/feature_settings_86
2022-01-07T15:38:29.105000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_153523/feature_settings_86/test_framework.log
2022-01-07T15:38:29.105000Z TestFramework (ERROR): 
2022-01-07T15:38:29.105000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_153523/feature_settings_86' to consolidate all logs
2022-01-07T15:38:29.105000Z TestFramework (ERROR): 
2022-01-07T15:38:29.105000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-07T15:38:29.105000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-07T15:38:29.105000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_settings.py
Bitcoin ABC functional tests with the next upgrade activated: feature_settings.py

PiRK updated this revision to Diff 31697.Jan 7 2022, 15:43

reverse the tests

PiRK planned changes to this revision.Jan 7 2022, 15:48

investigating CI error (the test works on my system)

Harbormaster completed remote builds in B17836: Diff 31697.Jan 7 2022, 15:52
teamcity added a comment.Jan 7 2022, 15:52
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_settings.py ======

------- Stdout: -------
2022-01-07T15:51:56.704000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220107_155022/feature_settings_86
2022-01-07T15:51:59.240000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 620, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 301, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_settings.py", line 87, in run_test
    match=ErrorMatch.PARTIAL_REGEX)
  File "/work/test/functional/test_framework/test_node.py", line 635, in assert_start_raises_init_error
    'Expected message "{}" does not partially match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 207, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Please check permissions." does not partially match stderr:
"Error: Failed loading settings file:
- Found duplicate key key in settings file /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220107_155022/feature_settings_86/node0/regtest/settings.json"
2022-01-07T15:51:59.291000Z TestFramework (INFO): Stopping nodes
2022-01-07T15:51:59.291000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220107_155022/feature_settings_86
2022-01-07T15:51:59.291000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220107_155022/feature_settings_86/test_framework.log
2022-01-07T15:51:59.291000Z TestFramework (ERROR): 
2022-01-07T15:51:59.291000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220107_155022/feature_settings_86' to consolidate all logs
2022-01-07T15:51:59.292000Z TestFramework (ERROR): 
2022-01-07T15:51:59.292000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-07T15:51:59.292000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-07T15:51:59.292000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_settings.py

teamcity added a comment.Jan 7 2022, 15:53
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_settings.py ======

------- Stdout: -------
2022-01-07T15:52:16.412000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220107_154753/feature_settings_86
2022-01-07T15:52:19.696000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 620, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 301, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_settings.py", line 87, in run_test
    match=ErrorMatch.PARTIAL_REGEX)
  File "/work/test/functional/test_framework/test_node.py", line 635, in assert_start_raises_init_error
    'Expected message "{}" does not partially match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 207, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Please check permissions." does not partially match stderr:
"Error: Failed loading settings file:
- Found duplicate key key in settings file /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220107_154753/feature_settings_86/node0/regtest/settings.json"
2022-01-07T15:52:19.746000Z TestFramework (INFO): Stopping nodes
2022-01-07T15:52:19.747000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220107_154753/feature_settings_86
2022-01-07T15:52:19.747000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220107_154753/feature_settings_86/test_framework.log
2022-01-07T15:52:19.747000Z TestFramework (ERROR): 
2022-01-07T15:52:19.747000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220107_154753/feature_settings_86' to consolidate all logs
2022-01-07T15:52:19.747000Z TestFramework (ERROR): 
2022-01-07T15:52:19.747000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-07T15:52:19.747000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-07T15:52:19.747000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_settings.py

Fabien requested changes to this revision.Jan 7 2022, 15:56

Back on your queue

teamcity added a comment.Jan 7 2022, 15:57
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_settings.py ======

------- Stdout: -------
2022-01-07T15:52:16.507000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_154912/feature_settings_86
2022-01-07T15:52:19.036000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 620, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 301, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_settings.py", line 87, in run_test
    match=ErrorMatch.PARTIAL_REGEX)
  File "/work/test/functional/test_framework/test_node.py", line 635, in assert_start_raises_init_error
    'Expected message "{}" does not partially match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 207, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Please check permissions." does not partially match stderr:
"Error: Failed loading settings file:
- Found duplicate key key in settings file /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_154912/feature_settings_86/node0/regtest/settings.json"
2022-01-07T15:52:19.087000Z TestFramework (INFO): Stopping nodes
2022-01-07T15:52:19.087000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_154912/feature_settings_86
2022-01-07T15:52:19.087000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_154912/feature_settings_86/test_framework.log
2022-01-07T15:52:19.087000Z TestFramework (ERROR): 
2022-01-07T15:52:19.088000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_154912/feature_settings_86' to consolidate all logs
2022-01-07T15:52:19.088000Z TestFramework (ERROR): 
2022-01-07T15:52:19.088000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-07T15:52:19.088000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-07T15:52:19.088000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: feature_settings.py ======

------- Stdout: -------
2022-01-07T15:56:11.409000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_155300/feature_settings_86
2022-01-07T15:56:13.888000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 620, in assert_start_raises_init_error
    self.wait_for_rpc_connection()
  File "/work/test/functional/test_framework/test_node.py", line 301, in wait_for_rpc_connection
    'bitcoind exited with status {} during initialization'.format(self.process.returncode)))
test_framework.test_node.FailedToStartError: [node 0] bitcoind exited with status 1 during initialization

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/feature_settings.py", line 87, in run_test
    match=ErrorMatch.PARTIAL_REGEX)
  File "/work/test/functional/test_framework/test_node.py", line 635, in assert_start_raises_init_error
    'Expected message "{}" does not partially match stderr:\n"{}"'.format(expected_msg, stderr))
  File "/work/test/functional/test_framework/test_node.py", line 207, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "Please check permissions." does not partially match stderr:
"Error: Failed loading settings file:
- Found duplicate key key in settings file /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_155300/feature_settings_86/node0/regtest/settings.json"
2022-01-07T15:56:13.940000Z TestFramework (INFO): Stopping nodes
2022-01-07T15:56:13.940000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_155300/feature_settings_86
2022-01-07T15:56:13.941000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_155300/feature_settings_86/test_framework.log
2022-01-07T15:56:13.941000Z TestFramework (ERROR): 
2022-01-07T15:56:13.942000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220107_155300/feature_settings_86' to consolidate all logs
2022-01-07T15:56:13.942000Z TestFramework (ERROR): 
2022-01-07T15:56:13.942000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-07T15:56:13.943000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-07T15:56:13.943000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_settings.py
Bitcoin ABC functional tests with the next upgrade activated: feature_settings.py

PiRK updated this revision to Diff 31698.Jan 7 2022, 16:08
PiRK edited the test plan for this revision. (Show Details)

reverting flaky functional test

Fabien accepted this revision.Jan 7 2022, 16:09
This revision is now accepted and ready to land.Jan 7 2022, 16:09
Harbormaster completed remote builds in B17837: Diff 31698.Jan 7 2022, 16:24
teamcity added a comment.Jan 7 2022, 16:24
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

tool_wallet.py --descriptors              | ✓ Passed  | 2 s
wallet_abandonconflict.py                 | ✓ Passed  | 11 s
wallet_address_types.py                   | ✓ Passed  | 16 s
wallet_address_types.py --descriptors     | ✓ Passed  | 12 s
wallet_avoidreuse.py                      | ✓ Passed  | 5 s
wallet_avoidreuse.py --descriptors        | ✓ Passed  | 5 s
wallet_backup.py                          | ✓ Passed  | 36 s
wallet_balance.py                         | ✓ Passed  | 7 s
wallet_balance.py --descriptors           | ✓ Passed  | 24 s
wallet_basic.py                           | ✓ Passed  | 20 s
wallet_coinbase_category.py               | ✓ Passed  | 1 s
wallet_create_tx.py                       | ✓ Passed  | 5 s
wallet_createwallet.py                    | ✓ Passed  | 2 s
wallet_createwallet.py --descriptors      | ✓ Passed  | 2 s
wallet_createwallet.py --usecli           | ✓ Passed  | 2 s
wallet_descriptor.py                      | ✓ Passed  | 7 s
wallet_disable.py                         | ✓ Passed  | 0 s
wallet_dump.py                            | ✓ Passed  | 4 s
wallet_encryption.py                      | ✓ Passed  | 5 s
wallet_encryption.py --descriptors        | ✓ Passed  | 5 s
wallet_hd.py                              | ✓ Passed  | 6 s
wallet_hd.py --descriptors                | ✓ Passed  | 5 s
wallet_import_rescan.py                   | ✓ Passed  | 5 s
wallet_import_with_label.py               | ✓ Passed  | 1 s
wallet_importdescriptors.py               | ✓ Passed  | 6 s
wallet_importmulti.py                     | ✓ Passed  | 3 s
wallet_importprunedfunds.py               | ✓ Passed  | 2 s
wallet_importprunedfunds.py --descriptors | ✓ Passed  | 2 s
wallet_keypool.py                         | ✓ Passed  | 3 s
wallet_keypool_topup.py                   | ✓ Passed  | 2 s
wallet_keypool_topup.py --descriptors     | ✓ Passed  | 3 s
wallet_labels.py                          | ✓ Passed  | 2 s
wallet_labels.py --descriptors            | ✓ Passed  | 1 s
wallet_listreceivedby.py                  | ✓ Passed  | 12 s
wallet_listsinceblock.py                  | ✓ Passed  | 4 s
wallet_listsinceblock.py --descriptors    | ✓ Passed  | 9 s
wallet_listtransactions.py                | ✓ Passed  | 26 s
wallet_listtransactions.py --descriptors  | ✓ Passed  | 12 s
wallet_multiwallet.py --usecli            | ✓ Passed  | 15 s
wallet_reorgsrestore.py                   | ✓ Passed  | 3 s
wallet_resendwallettransactions.py        | ✓ Passed  | 16 s
wallet_send.py                            | ✓ Passed  | 6 s
wallet_startup.py                         | ✓ Passed  | 2 s
wallet_txn_clone.py                       | ✓ Passed  | 2 s
wallet_txn_clone.py --mineblock           | ✓ Passed  | 3 s
wallet_txn_doublespend.py                 | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock     | ✓ Passed  | 3 s
wallet_watchonly.py                       | ✓ Passed  | 1 s
wallet_watchonly.py --usecli              | ✓ Passed  | 1 s

ALL                                       | ✓ Passed  | 1127 s (accumulated) 
Runtime: 226 s

----------------------------------------------------------------------
Ran 10 tests in 0.093s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
PiRK added a child revision: D10795: convert unsafe fs::path std::string conversion calls [1/7].Jan 10 2022, 12:51
This revision was landed with ongoing or failed builds.Jan 10 2022, 13:58
Closed by commit rABCddb02862f86c: error if settings.json exists, but is unreadable (authored by Tyler Chambers <me@tylerchambers.net>, committed by PiRK). · Explain Why
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCddb02862f86c: error if settings.json exists, but is unreadable.

Revision Contents
Changeset List

PathSize
src/
util/
10 lines

Diff 31727

View Options

src/util/settings.cpp

Loading...