Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC2665ae4c4589: convert unsafe fs::path std::string conversion calls [4/7] (test, fuzz…

Summary

This is a partial backport of core#22937 [2d/2g]
https://github.com/bitcoin/bitcoin/pull/22937/commits/6544ea5035268025207d2402db2f7d90fde947a6

The backport for this commit was split in to multiple commits to make review easier. This part deals with converting fs::string() calls that
will become unsafe when migrating from boost::filesystem to std::filesystem.

Depends on D10797

Test Plan

ninja all check-all bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 10 2022, 12:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2022, 12:59

PiRK requested review of this revision.Jan 10 2022, 12:59

teamcity edited the summary of this revision. (Show Details)Jan 10 2022, 12:59

PiRK added a child revision: D10799: convert unsafe fs::path std::string conversion calls [5/7] (util).Jan 10 2022, 13:01

Harbormaster completed remote builds in B17854: Diff 31717.Jan 10 2022, 13:24

PiRK retitled this revision from convert unsafe fs::path std::string conversion calls [4/7] to convert unsafe fs::path std::string conversion calls [4/7] (test, fuzz, wallet/test).Jan 10 2022, 15:12

PiRK edited the summary of this revision. (Show Details)

Fabien accepted this revision.Jan 11 2022, 09:49

This revision is now accepted and ready to land.Jan 11 2022, 09:49

Closed by commit rABC2665ae4c4589: convert unsafe fs::path std::string conversion calls [4/7] (test, fuzz… (authored by PiRK). · Explain WhyJan 11 2022, 12:27

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2665ae4c4589: convert unsafe fs::path std::string conversion calls [4/7] (test, fuzz….

PiRK mentioned this in D11972: convert unsafe fs::path std::string conversion call.Sep 13 2022, 13:06

PiRK mentioned this in rABCf673777f5179: convert unsafe fs::path std::string conversion call.Sep 14 2022, 06:39

convert unsafe fs::path std::string conversion calls [4/7] (test, fuzz, wallet/test)
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 31757

src/test/fuzz/banman.cpp

src/test/settings_tests.cpp

src/test/util/setup_common.cpp

src/test/util_tests.cpp

src/test/validation_tests.cpp

src/wallet/test/init_tests.cpp

src/wallet/test/wallet_tests.cpp

convert unsafe fs::path std::string conversion calls [4/7] (test, fuzz, wallet/test)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31757

src/test/fuzz/banman.cpp

src/test/settings_tests.cpp

src/test/util/setup_common.cpp

src/test/util_tests.cpp

src/test/validation_tests.cpp

src/wallet/test/init_tests.cpp

src/wallet/test/wallet_tests.cpp

convert unsafe fs::path std::string conversion calls [4/7] (test, fuzz, wallet/test)
ClosedPublic
Actions

Revision Contents
Changeset List