Paths

Table of Contentst

Differential D10785

refactor: Block unsafe fs::path std::string conversion calls
AbandonedPublic
Actions

Authored by PiRK on Jan 7 2022, 10:13.

Tags

None

Subscribers

None

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

There is no change in behavior. This just helps prepare for the
transition from boost::filesystem to std::filesystem by avoiding calls
to methods which will be unsafe after the transaction to std::filesystem
to due lack of a boost::filesystem::path::imbue equivalent and inability
to set a predictable locale.

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Co-authored-by: Kiminuo <kiminuo@protonmail.com>
Co-authored-by: MarcoFalke <falke.marco@gmail.com>

This is a backport of core#22937 [2/2]
https://github.com/bitcoin/bitcoin/pull/22937/commits/6544ea5035268025207d2402db2f7d90fde947a6

Depends on D10784, D10781, D10783

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr22937

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17824
Build 35474: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-debug · build-clang-tidy · build-clang
Build 35473: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 7 2022, 10:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2022, 10:13

PiRK requested review of this revision.Jan 7 2022, 10:13

teamcity edited the summary of this revision. (Show Details)Jan 7 2022, 10:13

Harbormaster completed remote builds in B17824: Diff 31684.Jan 7 2022, 11:05

abandoned in favor of D10795-D10801 (no changes, but commit split over 7 commits for easier reviewing)

PiRK abandoned this revision.Jan 10 2022, 13:07

Revision Contents
Changeset List

Path

Size

src/

11 lines

bitcoin-cli.cpp

4 lines

24 lines

4 lines

75 lines

10 lines

69 lines

interfaces/

6 lines

qt/

4 lines

4 lines

rpc/

11 lines

9 lines

2 lines

test/

fuzz/

2 lines

settings_tests.cpp

9 lines

util/

setup_common.cpp

4 lines

14 lines

validation_tests.cpp

2 lines

8 lines

util/

6 lines

16 lines

38 lines

wallet/

4 lines

38 lines

2 lines

18 lines

8 lines

2 lines

6 lines

test/

6 lines

init_test_fixture.cpp

8 lines

8 lines

wallet_tests.cpp

2 lines

7 lines

12 lines

2 lines

12 lines

Diff 31684

src/addrdb.cpp

Loading...

src/bitcoin-cli.cpp

Loading...

src/dbwrapper.cpp

Loading...

src/flatfile.cpp

Loading...

src/fs.h

Loading...

src/fs.cpp

Loading...

src/init.cpp

Loading...

src/interfaces/wallet.cpp

Loading...

src/qt/guiutil.cpp

Loading...

src/qt/intro.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/request.cpp

Loading...

src/rpc/server.cpp

Loading...

src/test/fuzz/banman.cpp

Loading...

src/test/settings_tests.cpp

Loading...

src/test/util/setup_common.cpp

Loading...

src/test/util_tests.cpp

Loading...

src/test/validation_tests.cpp

Loading...

src/torcontrol.cpp

Loading...

src/util/asmap.cpp

Loading...

src/util/settings.cpp

Loading...

src/util/system.cpp

Loading...

src/wallet/bdb.h

Loading...

src/wallet/bdb.cpp

Loading...

src/wallet/db.cpp

Loading...

src/wallet/load.cpp

Loading...

src/wallet/rpcdump.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/sqlite.cpp

Loading...

src/wallet/test/db_tests.cpp

Loading...

src/wallet/test/init_test_fixture.cpp

Loading...

src/wallet/test/init_tests.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...

src/wallet/wallet.cpp

Loading...

src/wallet/walletdb.cpp

Loading...

src/wallet/wallettool.cpp

Loading...

src/wallet/walletutil.cpp

Loading...