HomePhabricator

[backport#16898] scripted-diff: test: Replace connect_nodes_bi with…

Description

[backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes

Summary:
-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/connect_nodes_bi\(self.nodes,\s*(.),\s*/connect_nodes(self.nodes[\1], /g' $(git grep -l connect_nodes_bi)
sed -i --regexp-extended -e 's/connect_nodes_bi(,| )/connect_nodes\1/g' $(git grep -l connect_nodes_bi)
sed -i -- 's/connect_nodes_bi/connect_nodes/g' $(git grep -l connect_nodes_bi)
git restore test/functional/test_framework/util.py
-END VERIFY SCRIPT-

(script doesn't match our connect_nodes's API)

https://github.com/bitcoin/bitcoin/pull/16898/commits/fa3b9ee8b2280af4bcbcfffff275aaf8dd125929


Depends on D6490

Partial backport of Core PR16898

Test Plan:

ninja check-all

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D6492

Details

Provenance
majcostaAuthored on Jun 4 2020, 15:59
majcostaPushed on Jun 9 2020, 22:43
Reviewer
Restricted Project
Differential Revision
D6492: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes
Parents
rABC2804ca503a84: [backport#16898] test: Use connect_nodes when connecting nodes in the…
Branches
Unknown
Tags
Unknown