Differential D6490

[backport#16898] test: Use connect_nodes when connecting nodes in the test_framework
ClosedPublic
Actions

Authored by majcosta on Jun 9 2020, 19:38.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC2804ca503a84: [backport#16898] test: Use connect_nodes when connecting nodes in the…

Summary

https://github.com/bitcoin/bitcoin/pull/16898/commits/faaee1e39a91b3f603881655d3980c29af09852b

Partial backport of Core PR16898

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 9 2020, 19:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2020, 19:38

majcosta requested review of this revision.Jun 9 2020, 19:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11368: Diff 21184.Jun 9 2020, 20:01

majcosta added a child revision: D6492: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes.Jun 9 2020, 20:36

jasonbcox requested changes to this revision.Jun 9 2020, 20:55

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

test/functional/p2p_disconnect_ban.py
13 ↗	(On Diff #21184)	should be able to remove this
122 ↗	(On Diff #21184)	missed one
test/functional/test_framework/test_framework.py
26 ↗	(On Diff #21184)	should be able to clean this up too

This revision now requires changes to proceed.Jun 9 2020, 20:55

Looks like other parts of the stack take care of it.

This revision is now accepted and ready to land.Jun 9 2020, 21:11

Closed by commit rABC2804ca503a84: [backport#16898] test: Use connect_nodes when connecting nodes in the… (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJun 9 2020, 21:31

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC2804ca503a84: [backport#16898] test: Use connect_nodes when connecting nodes in the….

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_disconnect_ban.py

9 lines

p2p_tx_download.py

1 line

11 lines

test_framework/

test_framework.py

13 lines

wallet_listsinceblock.py

12 lines

Diff 21196

test/functional/p2p_disconnect_ban.py

Loading...

test/functional/p2p_tx_download.py

Loading...

test/functional/rpc_net.py

Loading...

test/functional/test_framework/test_framework.py

Loading...

test/functional/wallet_listsinceblock.py

Loading...