Page MenuHomePhabricator

[backport#16898] test: Use connect_nodes when connecting nodes in the test_framework
ClosedPublic

Authored by majcosta on Jun 9 2020, 19:38.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta requested review of this revision.Jun 9 2020, 19:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox requested changes to this revision.Jun 9 2020, 20:55
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/p2p_disconnect_ban.py
13 ↗(On Diff #21184)

should be able to remove this

122 ↗(On Diff #21184)

missed one

test/functional/test_framework/test_framework.py
26 ↗(On Diff #21184)

should be able to clean this up too

This revision now requires changes to proceed.Jun 9 2020, 20:55

Looks like other parts of the stack take care of it.

This revision is now accepted and ready to land.Jun 9 2020, 21:11