HomePhabricator

qa: Only allow disconnecting all NodeConns

Description

qa: Only allow disconnecting all NodeConns

Summary:

Disconnecting the connection with index=0 makes no sense when there are
more than one connections, as the list "rotates around" and populates
index 0 after del.

Just disconnect all NodeConns in any case.

Backport of core PR11641

Test Plan:

./test/functional/test_runner.py --extended

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2356

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Nov 8 2017, 21:28
FabienCommitted on Jan 21 2019, 17:47
FabienPushed on Jan 21 2019, 17:47
Reviewer
Restricted Project
Differential Revision
D2356: qa: Only allow disconnecting all NodeConns
Parents
rABC5158d7f79c63: [RCU] Use assert in tests instead of BOOST_CHECK when they aren't in the main…
Branches
Unknown
Tags
Unknown

Event Timeline