qa: Only allow disconnecting all NodeConns
ClosedPublic
Actions

Authored by Fabien on Jan 21 2019, 08:44.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING68ba9a48f885: qa: Only allow disconnecting all NodeConns
rABC68ba9a48f885: qa: Only allow disconnecting all NodeConns

Summary

Disconnecting the connection with index=0 makes no sense when there are
more than one connections, as the list "rotates around" and populates
index 0 after del.

Just disconnect all NodeConns in any case.

Backport of core PR11641

Test Plan

./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 21 2019, 08:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 08:44

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4600: Diff 6770.Jan 21 2019, 08:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien added a child revision: D2357: [tests] Remove mininode periodic (half-hour) ping messages.Jan 21 2019, 08:55

deadalnix accepted this revision.Jan 21 2019, 16:59

This revision is now accepted and ready to land.Jan 21 2019, 16:59

Closed by commit rABC68ba9a48f885: qa: Only allow disconnecting all NodeConns (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJan 21 2019, 17:47

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING68ba9a48f885: qa: Only allow disconnecting all NodeConns.Sep 18 2019, 21:59

Revision Contents
Changeset List

Path

Size

test/

functional/

maxuploadtarget.py

5 lines

p2p-acceptblock.py

4 lines

p2p-leaktests.py

3 lines

test_framework/

test_node.py

14 lines

Diff 6789

View Options

test/functional/maxuploadtarget.py

View Options

test/functional/p2p-acceptblock.py

View Options

test/functional/p2p-leaktests.py

View Options

test/functional/test_framework/test_node.py

qa: Only allow disconnecting all NodeConnsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6789

test/functional/maxuploadtarget.py

test/functional/p2p-acceptblock.py

test/functional/p2p-leaktests.py

test/functional/test_framework/test_node.py

qa: Only allow disconnecting all NodeConns
ClosedPublic
Actions

Revision Contents
Changeset List