Page MenuHomePhabricator

qa: Only allow disconnecting all NodeConns
ClosedPublic

Authored by Fabien on Jan 21 2019, 08:44.

Details

Summary
Disconnecting the connection with index=0 makes no sense when there are
more than one connections, as the list "rotates around" and populates
index 0 after del.

Just disconnect all NodeConns in any case.

Backport of core PR11641

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11641
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4600
Build 7263: Bitcoin ABC Buildbot (legacy)
Build 7262: arc lint + arc unit