HomePhabricator

[logging] Don't log REJECT code when transaction is rejected

Description

[logging] Don't log REJECT code when transaction is rejected

Summary:

Remove the BIP61 REJECT code from error messages and logs when a
transaction is rejected.

BIP61 support was removed in
fa25f43ac5692082dba3f90456c501eb08f1b75c. The REJECT codes will be
removed from the codebase entirely in the following commit.

This is a backport of Core PR17004 [2/5]
Commit https://github.com/bitcoin/bitcoin/pull/17004/commits/0053e16714323c1694c834fdca74f064a1a33529

Depends on D8181

Test Plan: ninja all check-all

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox, deadalnix

Subscribers: jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D8182

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Oct 29 2020, 21:44
PiRKCommitted on Oct 29 2020, 21:45
abc-botPushed on Oct 29 2020, 21:50
Reviewer
Restricted Owners Package
Differential Revision
D8182: [logging] Don't log REJECT code when transaction is rejected
Parents
rABC8a980e61c9f8: [validation] Fix peer punishment for bad blocks
Branches
Unknown
Tags
Unknown