[logging] Don't log REJECT code when transaction is rejected
ClosedPublic
Actions

Authored by PiRK on Oct 29 2020, 17:38.

Details

Reviewers

jasonbcox
deadalnix

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC6c4d530bf35c: [logging] Don't log REJECT code when transaction is rejected

Summary

Remove the BIP61 REJECT code from error messages and logs when a
transaction is rejected.

BIP61 support was removed in
fa25f43ac5692082dba3f90456c501eb08f1b75c. The REJECT codes will be
removed from the codebase entirely in the following commit.

This is a backport of Core PR17004 [2/5]
Commit https://github.com/bitcoin/bitcoin/pull/17004/commits/0053e16714323c1694c834fdca74f064a1a33529

Depends on D8181

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 29 2020, 17:38

Owners added a reviewer: Restricted Owners Package.Oct 29 2020, 17:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2020, 17:38

PiRK requested review of this revision.Oct 29 2020, 17:38

teamcity edited the summary of this revision. (Show Details)Oct 29 2020, 17:39

PiRK edited the summary of this revision. (Show Details)Oct 29 2020, 17:39

PiRK added a parent revision: D8181: [validation] Fix peer punishment for bad blocks.

PiRK added a child revision: D8183: [validation] Remove REJECT code from CValidationState.Oct 29 2020, 17:45

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-mempool-coherence-on-activations.py ======

------- Stdout: -------
2020-10-29T17:55:50.113000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-mempool-coherence-on-activations_579
2020-10-29T17:55:51.353000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-mempool-coherence-on-activations.py", line 270, in run_test
    node.sendrawtransaction, ToHex(tx_post0))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T17:55:51.407000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:55:51.559000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-mempool-coherence-on-activations_579
2020-10-29T17:55:51.559000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-mempool-coherence-on-activations_579/test_framework.log
2020-10-29T17:55:51.559000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-mempool-coherence-on-activations_579' to consolidate all logs
====== Bitcoin ABC functional tests: abc-replay-protection.py ======

------- Stdout: -------
2020-10-29T17:55:50.883000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-replay-protection_581
2020-10-29T17:55:51.636000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-replay-protection.py", line 196, in run_test
    node.sendrawtransaction, ToHex(replay_txns[1]))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T17:55:51.687000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:55:51.939000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-replay-protection_581
2020-10-29T17:55:51.939000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-replay-protection_581/test_framework.log
2020-10-29T17:55:51.940000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-replay-protection_581' to consolidate all logs
====== Bitcoin ABC functional tests: abc-segwit-recovery.py ======

------- Stdout: -------
2020-10-29T17:55:51.664000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-segwit-recovery_584
2020-10-29T17:55:52.804000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Extra items left on stack after execution) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-segwit-recovery.py", line 264, in run_test
    node_nonstd.sendrawtransaction, ToHex(txspend))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'non-mandatory-script-verify-flag (Extra items left on stack after execution) (code 64)'
error message: 'non-mandatory-script-verify-flag (Extra items left on stack after execution)'.
2020-10-29T17:55:52.855000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:55:53.107000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-segwit-recovery_584
2020-10-29T17:55:53.107000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-segwit-recovery_584/test_framework.log
2020-10-29T17:55:53.107000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_175503/abc-segwit-recovery_584' to consolidate all logs

Harbormaster completed remote builds in B13751: Diff 25241.Oct 29 2020, 17:57

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-mempool-coherence-on-activations.py ======

------- Stdout: -------
2020-10-29T17:56:31.662000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-mempool-coherence-on-activations_343
2020-10-29T17:56:33.044000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-mempool-coherence-on-activations.py", line 270, in run_test
    node.sendrawtransaction, ToHex(tx_post0))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T17:56:33.095000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:56:33.346000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-mempool-coherence-on-activations_343
2020-10-29T17:56:33.346000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-mempool-coherence-on-activations_343/test_framework.log
2020-10-29T17:56:33.346000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-mempool-coherence-on-activations_343' to consolidate all logs
====== Bitcoin ABC functional tests: abc-replay-protection.py ======

------- Stdout: -------
2020-10-29T17:56:32.072000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-replay-protection_345
2020-10-29T17:56:32.873000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-replay-protection.py", line 196, in run_test
    node.sendrawtransaction, ToHex(replay_txns[1]))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T17:56:32.924000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:56:33.175000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-replay-protection_345
2020-10-29T17:56:33.175000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-replay-protection_345/test_framework.log
2020-10-29T17:56:33.175000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-replay-protection_345' to consolidate all logs
====== Bitcoin ABC functional tests: abc-segwit-recovery.py ======

------- Stdout: -------
2020-10-29T17:56:33.254000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-segwit-recovery_348
2020-10-29T17:56:34.697000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Extra items left on stack after execution) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-segwit-recovery.py", line 264, in run_test
    node_nonstd.sendrawtransaction, ToHex(txspend))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'non-mandatory-script-verify-flag (Extra items left on stack after execution) (code 64)'
error message: 'non-mandatory-script-verify-flag (Extra items left on stack after execution)'.
2020-10-29T17:56:34.748000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:56:35.000000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-segwit-recovery_348
2020-10-29T17:56:35.000000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-segwit-recovery_348/test_framework.log
2020-10-29T17:56:35.000000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc-segwit-recovery_348' to consolidate all logs
====== Bitcoin ABC functional tests: abc_wallet_standardness.py ======

------- Stdout: -------
2020-10-29T17:56:33.421000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc_wallet_standardness_349
2020-10-29T17:56:34.950000Z TestFramework (INFO): Trying script 21022bf2e9c1f416d65f1488d378abeeb63089bc8edb82ef02981db1b28e2408cc84ac
2020-10-29T17:56:35.994000Z TestFramework (INFO): Trying script 4c21022bf2e9c1f416d65f1488d378abeeb63089bc8edb82ef02981db1b28e2408cc84ac
2020-10-29T17:56:36.018000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: scriptpubkey (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc_wallet_standardness.py", line 147, in run_test
    sign_error='Data push larger than necessary')
  File "/work/test/functional/abc_wallet_standardness.py", line 89, in fund_and_test_wallet
    std_node.sendrawtransaction, rawtx)
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'scriptpubkey (code 64)'
error message: 'scriptpubkey'.
2020-10-29T17:56:36.069000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:56:36.321000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc_wallet_standardness_349
2020-10-29T17:56:36.322000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc_wallet_standardness_349/test_framework.log
2020-10-29T17:56:36.322000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/abc_wallet_standardness_349' to consolidate all logs
====== Bitcoin ABC functional tests: mining_prioritisetransaction.py ======

------- Stdout: -------
2020-10-29T17:56:06.651000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/mining_prioritisetransaction_317
2020-10-29T17:56:13.310000Z TestFramework (INFO): Assert that prioritised transaction was mined
2020-10-29T17:56:14.117000Z TestFramework (INFO): Assert that de-prioritised transaction is still in mempool
2020-10-29T17:56:14.555000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: min relay fee not met (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/mining_prioritisetransaction.py", line 193, in run_test
    self.nodes[0].sendrawtransaction, tx_hex)
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'min relay fee not met (code 66)'
error message: 'min relay fee not met'.
2020-10-29T17:56:14.606000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:56:14.859000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/mining_prioritisetransaction_317
2020-10-29T17:56:14.859000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/mining_prioritisetransaction_317/test_framework.log
2020-10-29T17:56:14.859000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_175346/mining_prioritisetransaction_317' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: abc-mempool-coherence-on-activations.py
Bitcoin ABC functional tests: abc-replay-protection.py
Bitcoin ABC functional tests: abc-segwit-recovery.py
Bitcoin ABC functional tests: abc_wallet_standardness.py
Bitcoin ABC functional tests: mining_prioritisetransaction.py

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-mempool-coherence-on-activations.py ======

------- Stdout: -------
2020-10-29T17:56:23.825000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-mempool-coherence-on-activations_549
2020-10-29T17:56:25.218000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-mempool-coherence-on-activations.py", line 270, in run_test
    node.sendrawtransaction, ToHex(tx_post0))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T17:56:25.269000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:56:25.520000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-mempool-coherence-on-activations_549
2020-10-29T17:56:25.520000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-mempool-coherence-on-activations_549/test_framework.log
2020-10-29T17:56:25.521000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-mempool-coherence-on-activations_549' to consolidate all logs
====== Bitcoin ABC functional tests: abc-replay-protection.py ======

------- Stdout: -------
2020-10-29T17:56:25.295000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-replay-protection_551
2020-10-29T17:56:26.304000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-replay-protection.py", line 196, in run_test
    node.sendrawtransaction, ToHex(replay_txns[1]))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T17:56:26.358000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:56:26.660000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-replay-protection_551
2020-10-29T17:56:26.661000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-replay-protection_551/test_framework.log
2020-10-29T17:56:26.661000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-replay-protection_551' to consolidate all logs
====== Bitcoin ABC functional tests: abc-segwit-recovery.py ======

------- Stdout: -------
2020-10-29T17:56:26.751000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-segwit-recovery_554
2020-10-29T17:56:27.986000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Extra items left on stack after execution) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-segwit-recovery.py", line 264, in run_test
    node_nonstd.sendrawtransaction, ToHex(txspend))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'non-mandatory-script-verify-flag (Extra items left on stack after execution) (code 64)'
error message: 'non-mandatory-script-verify-flag (Extra items left on stack after execution)'.
2020-10-29T17:56:28.039000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:56:28.296000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-segwit-recovery_554
2020-10-29T17:56:28.296000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-segwit-recovery_554/test_framework.log
2020-10-29T17:56:28.296000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc-segwit-recovery_554' to consolidate all logs
====== Bitcoin ABC functional tests: abc_wallet_standardness.py ======

------- Stdout: -------
2020-10-29T17:56:26.751000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc_wallet_standardness_555
2020-10-29T17:56:27.239000Z TestFramework (INFO): Trying script 21034ad73f0432b47126518b2d8748073dace5c95758e9f1a817cd26383cafbec038ac
2020-10-29T17:56:27.266000Z TestFramework (INFO): Trying script 4c21034ad73f0432b47126518b2d8748073dace5c95758e9f1a817cd26383cafbec038ac
2020-10-29T17:56:27.283000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: scriptpubkey (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc_wallet_standardness.py", line 147, in run_test
    sign_error='Data push larger than necessary')
  File "/work/test/functional/abc_wallet_standardness.py", line 89, in fund_and_test_wallet
    std_node.sendrawtransaction, rawtx)
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'scriptpubkey (code 64)'
error message: 'scriptpubkey'.
2020-10-29T17:56:27.335000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:56:27.541000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc_wallet_standardness_555
2020-10-29T17:56:27.541000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc_wallet_standardness_555/test_framework.log
2020-10-29T17:56:27.541000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/abc_wallet_standardness_555' to consolidate all logs
====== Bitcoin ABC functional tests: mining_prioritisetransaction.py ======

------- Stdout: -------
2020-10-29T17:55:59.538000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/mining_prioritisetransaction_523
2020-10-29T17:56:03.658000Z TestFramework (INFO): Assert that prioritised transaction was mined
2020-10-29T17:56:03.927000Z TestFramework (INFO): Assert that de-prioritised transaction is still in mempool
2020-10-29T17:56:04.187000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: min relay fee not met (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/mining_prioritisetransaction.py", line 193, in run_test
    self.nodes[0].sendrawtransaction, tx_hex)
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'min relay fee not met (code 66)'
error message: 'min relay fee not met'.
2020-10-29T17:56:04.238000Z TestFramework (INFO): Stopping nodes
2020-10-29T17:56:04.741000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/mining_prioritisetransaction_523
2020-10-29T17:56:04.741000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/mining_prioritisetransaction_523/test_framework.log
2020-10-29T17:56:04.741000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_175416/mining_prioritisetransaction_523' to consolidate all logs