Page MenuHomePhabricator
Differential D8183

[validation] Remove REJECT code from CValidationState
ClosedPublic
Actions

Authored by PiRK on Oct 29 2020, 17:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCaaa6b819c0dd: [validation] Remove REJECT code from CValidationState
Summary

We no longer send BIP 61 REJECT messages, so there's no need to set
a REJECT code in the CValidationState object.

This is a backport of Core PR17004 [3/5]
Commit https://github.com/bitcoin/bitcoin/pull/17004/commits/e9d5a59e34ff2d538d8f5315efd9908bf24d0fdc
Depends on D8182

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 29 2020, 17:45
Owners added a reviewer: Restricted Owners Package.Oct 29 2020, 17:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2020, 17:45
PiRK requested review of this revision.Oct 29 2020, 17:45
teamcity edited the summary of this revision. (Show Details)Oct 29 2020, 17:45
PiRK added a child revision: D8184: [validation] Fix REJECT message comments.Oct 29 2020, 17:48
Harbormaster completed remote builds in B13752: Diff 25242.Oct 29 2020, 18:08
deadalnix accepted this revision.Oct 29 2020, 18:20
This revision is now accepted and ready to land.Oct 29 2020, 18:20
PiRK mentioned this in D8182: [logging] Don't log REJECT code when transaction is rejected.Oct 29 2020, 18:22
PiRK updated this revision to Diff 25246.Oct 29 2020, 18:26

rebase after moving some functional tests to previous commit D8182

Harbormaster completed remote builds in B13756: Diff 25246.Oct 29 2020, 18:49
Closed by commit rABCaaa6b819c0dd: [validation] Remove REJECT code from CValidationState (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyOct 30 2020, 07:19
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCaaa6b819c0dd: [validation] Remove REJECT code from CValidationState.

Revision Contents
Changeset List

PathSize
src/
avalanche/
4 lines
consensus/
24 lines
20 lines
27 lines
test/
1 line
2 lines
1 line
11 lines
104 lines

Diff 25256

View Options

src/avalanche/validation.h

Loading...
View Options

src/consensus/tx_check.cpp

Loading...
View Options

src/consensus/tx_verify.cpp

Loading...
View Options

src/consensus/validation.h

Loading...
View Options

src/test/blockcheck_tests.cpp

Loading...
View Options

src/test/checkpoints_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...