HomePhabricator

Merge #11351: Refactor: Modernize disallowed copy constructors/assignment

Description

Merge #11351: Refactor: Modernize disallowed copy constructors/assignment

Summary:
2a07f878a Refactor: Modernize disallowed copy constructors/assignment (Dan Raviv)

Pull request description:

Use C++11's better capability of expressing an interface of a non-copyable class by publicly deleting its copy ctor and assignment operator instead of just declaring them private.

Tree-SHA512: 878f446be5a136bb2a90643aaeaca62948b575e6ef71ccc5b4b8f373e66f36ced00665128f36504e0ccfee639863d969329c4276154ef9f2a9de9137f0801e01

Backport of Core PR11351
https://github.com/bitcoin/bitcoin/pull/11351

Test Plan:
make check
test_runner.py

Reviewers: jasonbcox, deadalnix, Fabien, O1 Bitcoin ABC, #bitcoin_abc, markblundeberg

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, markblundeberg

Subscribers: markblundeberg

Differential Revision: https://reviews.bitcoinabc.org/D2983

Details

Provenance
Pieter Wuille <pieter.wuille@gmail.com>Authored on Sep 22 2017, 05:33
nakihitoCommitted on May 10 2019, 18:08
nakihitoPushed on May 10 2019, 18:08
Reviewer
Restricted Owners Package
Differential Revision
D2983: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment
Parents
rABC70295b86c562: Merge #11155: Trivial: Documentation fixes for CVectorWriter ctors
Branches
Unknown
Tags
Unknown

Event Timeline

Nico Guiton <nico@bitframe.org> committed rABC6f47fcfacfed: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment (authored by Pieter Wuille <pieter.wuille@gmail.com>).May 10 2019, 18:08