Page MenuHomePhabricator

Merge #11351: Refactor: Modernize disallowed copy constructors/assignment
ClosedPublic

Authored by nakihito on Wed, May 8, 02:10.

Details

Reviewers
jasonbcox
deadalnix
Fabien
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC6f47fcfacfed: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment
Summary

2a07f878a Refactor: Modernize disallowed copy constructors/assignment (Dan Raviv)

Pull request description:

Use C++11's better capability of expressing an interface of a non-copyable class by publicly deleting its copy ctor and assignment operator instead of just declaring them private.

Tree-SHA512: 878f446be5a136bb2a90643aaeaca62948b575e6ef71ccc5b4b8f373e66f36ced00665128f36504e0ccfee639863d969329c4276154ef9f2a9de9137f0801e01

Backport of Core PR11351
https://github.com/bitcoin/bitcoin/pull/11351

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Wed, May 8, 02:10
Owners added a reviewer: Restricted Owners Package.Wed, May 8, 02:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, May 8, 02:10
markblundeberg requested changes to this revision.Wed, May 8, 03:22
markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
src/txdb.h
118 ↗(On Diff #8490)

please leave this out, per D2983 (serves me right for backporting out-of-order =D )

This revision now requires changes to proceed.Wed, May 8, 03:22
markblundeberg added inline comments.Wed, May 8, 03:23
src/txdb.h
118 ↗(On Diff #8490)

err sorry, I mean D2901

nakihito updated this revision to Diff 8603.Fri, May 10, 17:53

Removed changes in txdb.h.

markblundeberg accepted this revision.Fri, May 10, 18:00

Looks good, thanks!

This revision is now accepted and ready to land.Fri, May 10, 18:00