Page MenuHomePhabricator
Differential D2983

Merge #11351: Refactor: Modernize disallowed copy constructors/assignment
ClosedPublic
Actions

Authored by nakihito on May 8 2019, 02:10.

Details

Reviewers
jasonbcox
deadalnix
Fabien
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING6f47fcfacfed: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment
rABC6f47fcfacfed: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment
Summary

2a07f878a Refactor: Modernize disallowed copy constructors/assignment (Dan Raviv)

Pull request description:

Use C++11's better capability of expressing an interface of a non-copyable class by publicly deleting its copy ctor and assignment operator instead of just declaring them private.

Tree-SHA512: 878f446be5a136bb2a90643aaeaca62948b575e6ef71ccc5b4b8f373e66f36ced00665128f36504e0ccfee639863d969329c4276154ef9f2a9de9137f0801e01

Backport of Core PR11351
https://github.com/bitcoin/bitcoin/pull/11351

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11351
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5747
Build 9556: Bitcoin ABC Buildbot (legacy)
Build 9555: arc lint + arc unit

Event Timeline

nakihito created this revision.May 8 2019, 02:10
Owners added a reviewer: Restricted Owners Package.May 8 2019, 02:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2019, 02:10
teamcity added a comment.May 8 2019, 02:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 8 2019, 02:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5747: Diff 8490.May 8 2019, 02:26
markblundeberg requested changes to this revision.May 8 2019, 03:22
markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
src/txdb.h
118

please leave this out, per D2983 (serves me right for backporting out-of-order =D )

This revision now requires changes to proceed.May 8 2019, 03:22
markblundeberg added inline comments.May 8 2019, 03:23
src/txdb.h
118

err sorry, I mean D2901

nakihito updated this revision to Diff 8603.May 10 2019, 17:53

Removed changes in txdb.h.

teamcity added a comment.May 10 2019, 17:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg accepted this revision.May 10 2019, 18:00

Looks good, thanks!

This revision is now accepted and ready to land.May 10 2019, 18:00
teamcity added a comment.May 10 2019, 18:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5808: Diff 8603.May 10 2019, 18:08
Closed by commit rABC6f47fcfacfed: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyMay 10 2019, 18:09
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING6f47fcfacfed: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment.Sep 18 2019, 23:29

Revision Contents
Changeset List

PathSize
src/
12 lines
5 lines
16 lines
support/
16 lines
3 lines
wallet/
7 lines
5 lines

Diff 8490

View Options

src/coins.h

Loading...
View Options

src/net.h

Loading...
View Options

src/streams.h

Loading...
View Options

src/support/lockedpool.h

Loading...
View Options

src/txdb.h

Loading...
View Options

src/wallet/db.h

Loading...
View Options

src/wallet/walletdb.h

Loading...