Page MenuHomePhabricator

Merge #11351: Refactor: Modernize disallowed copy constructors/assignment
ClosedPublic

Authored by nakihito on May 8 2019, 02:10.

Details

Summary

2a07f878a Refactor: Modernize disallowed copy constructors/assignment (Dan Raviv)

Pull request description:

Use C++11's better capability of expressing an interface of a non-copyable class by publicly deleting its copy ctor and assignment operator instead of just declaring them private.

Tree-SHA512: 878f446be5a136bb2a90643aaeaca62948b575e6ef71ccc5b4b8f373e66f36ced00665128f36504e0ccfee639863d969329c4276154ef9f2a9de9137f0801e01

Backport of Core PR11351
https://github.com/bitcoin/bitcoin/pull/11351

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11351
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5808
Build 9678: Bitcoin ABC Buildbot (legacy)
Build 9677: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.May 8 2019, 02:10
markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
src/txdb.h
118 ↗(On Diff #8490)

please leave this out, per D2983 (serves me right for backporting out-of-order =D )

This revision now requires changes to proceed.May 8 2019, 03:22
src/txdb.h
118 ↗(On Diff #8490)

err sorry, I mean D2901

Removed changes in txdb.h.

This revision is now accepted and ready to land.May 10 2019, 18:00