HomePhabricator

[LINTER] Fix some PHP linter rules

Authored by Fabien on Jun 11 2019, 13:08.

Description

[LINTER] Fix some PHP linter rules

Summary:
Disable 2 generic rules:

  • The limit in cyclomatic complexity, whose value is not configurable.

Phabricator does not enforce this rule, and the hardcoded value is very
restrictive.

  • Enforce no space after a cast. Actually both 0 space and 1 space are

enforced, causing conflicts (there is no cast in the PHP codebase yet).

Test Plan:

arc lint --everything

Should return no error.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3287

Details

Committed
FabienJun 12 2019, 08:46
Pushed
FabienJun 12 2019, 08:46
Reviewer
Restricted Project
Differential Revision
D3287: [LINTER] Fix some PHP linter rules
Parents
rABC882b9d780536: Fix make distcheck
Branches
Unknown
Tags
Unknown