Page MenuHomePhabricator

[LINTER] Fix some PHP linter rules
ClosedPublic

Authored by Fabien on Tue, Jun 11, 13:54.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC70635fc8ac4b: [LINTER] Fix some PHP linter rules
Summary

Disable 2 generic rules:

  • The limit in cyclomatic complexity, whose value is not configurable.

Phabricator does not enforce this rule, and the hardcoded value is very
restrictive.

  • Enforce no space after a cast. Actually both 0 space and 1 space are

enforced, causing conflicts (there is no cast in the PHP codebase yet).

Test Plan
arc lint --everything

Should return no error.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jun 11, 13:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jun 11, 13:54
deadalnix accepted this revision.Tue, Jun 11, 23:46
This revision is now accepted and ready to land.Tue, Jun 11, 23:46
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.