HomePhabricator

rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump)

Description

rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump)

Summary:
This concludes backport of core#19717 [4/4]
https://github.com/bitcoin/bitcoin/pull/19717/commits/fa3d9ce3254882c545d700990fe8e9a678f31eed

Depends on D10147, D10149 and D10159

Note: the forward declaration of RPC functions in rpcwallet.cpp don't seem to exist in Bitcoin ABC, and the ones in wallet_tests.cpp were in rpcdump.h (see D45)

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10148

Details

Provenance
PiRKAuthored on Sep 20 2021, 08:03
PiRKPushed on Sep 20 2021, 09:26
Reviewer
Restricted Project
Differential Revision
D10148: rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump)
Parents
rABCe77656ba8140: factor two very similar error messages
Branches
Unknown
Tags
Unknown