factor two very similar error messages
ClosedPublic
Actions

Authored by PiRK on Sep 20 2021, 08:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCe77656ba8140: factor two very similar error messages

Summary

Instead of changing the layout of the two messages in D10148 because of the change of indentation, create a static function that build this message.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 20 2021, 08:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2021, 08:01

PiRK requested review of this revision.Sep 20 2021, 08:01

Fabien accepted this revision.Sep 20 2021, 08:03

This revision is now accepted and ready to land.Sep 20 2021, 08:03

PiRK added a child revision: D10148: rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump).Sep 20 2021, 08:07

remove accidental int64_t references (I did not intend to commit those, it was me testing)

Harbormaster completed remote builds in B16714: Diff 30058.Sep 20 2021, 08:16

Harbormaster completed remote builds in B16716: Diff 30060.Sep 20 2021, 08:27

Closed by commit rABCe77656ba8140: factor two very similar error messages (authored by PiRK). · Explain WhySep 20 2021, 09:28

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe77656ba8140: factor two very similar error messages.

PiRK mentioned this in D17927: rpc: Improve importdescriptor RPC error messages.Sat, Apr 12, 08:01

PiRK mentioned this in rABC0131c1a63c9e: rpc: Improve importdescriptor RPC error messages.Mon, Apr 14, 10:58

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcdump.cpp

62 lines

Diff 30069

View Options

factor two very similar error messagesClosedPublicActions