Page MenuHomePhabricator
Differential D10146

rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining)
ClosedPublic
Actions

Authored by PiRK on Sep 17 2021, 14:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9fe6e28e86f1: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining)
Summary

This is a backport of core#19717 [2/4]
https://github.com/bitcoin/bitcoin/pull/19717/commits/faaa46dc204d6d714f71dbc6f0bf02215dba0f0f

Note: the double \n in rpc_generate.py is required because of D7184

Depends on D10145 and D10149

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 17 2021, 14:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2021, 14:12
PiRK requested review of this revision.Sep 17 2021, 14:12
teamcity edited the summary of this revision. (Show Details)Sep 17 2021, 14:13
PiRK added a child revision: D10147: rpc: Assert that RPCArg names are equal to CRPCCommand ones (zmq).Sep 17 2021, 14:13
Harbormaster completed remote builds in B16692: Diff 30027.Sep 17 2021, 14:32
PiRK planned changes to this revision.Sep 17 2021, 15:08

needs rebasing after D10149

PiRK updated this revision to Diff 30033.EditedSep 17 2021, 15:49
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D10149: Make all CRPCCommand actors take a const Config &.

rebase onto D10149 and use const Config &

Harbormaster completed remote builds in B16698: Diff 30033.Sep 17 2021, 16:03
Fabien requested changes to this revision.Sep 19 2021, 05:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpc_generate.py
21 ↗(On Diff #30033)

Duplicated \n, and please fix the layout while you're at it

This revision now requires changes to proceed.Sep 19 2021, 05:16
PiRK updated this revision to Diff 30048.Sep 19 2021, 09:23

fix the layout of the generate help message

The extra \n is required because of D7184, which standardizes our help messages to always print a blank line between the command and the description.

Harbormaster completed remote builds in B16707: Diff 30048.Sep 19 2021, 09:37
Fabien requested changes to this revision.Sep 20 2021, 07:11
Fabien added inline comments.
test/functional/rpc_generate.py
23 ↗(On Diff #30048)

OK for the double \n, but please make the formatting consistent with the other parts of the code:

  • no need to put the \n on its own line
  • the space is at the end of the line, not the beginning
This revision now requires changes to proceed.Sep 20 2021, 07:11
PiRK updated this revision to Diff 30057.Sep 20 2021, 07:24

put space at the end of the line, and second newline with the previous line

Harbormaster completed remote builds in B16713: Diff 30057.Sep 20 2021, 07:37
Fabien accepted this revision.Sep 20 2021, 07:54
This revision is now accepted and ready to land.Sep 20 2021, 07:54
Closed by commit rABC9fe6e28e86f1: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining) (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhySep 20 2021, 09:28
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC9fe6e28e86f1: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining).

Revision Contents
Changeset List

PathSize
src/
rpc/
1026 lines
test/
functional/
5 lines

Diff 30068

View Options

src/rpc/mining.cpp

Loading...
View Options

test/functional/rpc_generate.py

Loading...