HomePhabricator

Remove undue lock assertion in GuessVerificationProgess

Description

Remove undue lock assertion in GuessVerificationProgess

Summary:
The AssertLockHeld() assumes that cs_main is always locked when
calling GuessVerificationProgress().
However, as stated in the function comment, this might not always be
true as the lock is only required under some circumstances. The
assertion is then too restrictive.
Note that this makes our code in sync with current core codebase.

Test Plan:
With debug enabled:

make check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4549

Details

Provenance
FabienAuthored on Nov 26 2019, 09:26
FabienPushed on Nov 26 2019, 11:06
Reviewer
Restricted Project
Differential Revision
D4549: Remove undue lock assertion in GuessVerificationProgess
Parents
rABC1fd348979cfd: Revert use of size_t in ParseParameters
Branches
Unknown
Tags
Unknown