Page MenuHomePhabricator

Remove undue lock assertion in GuessVerificationProgess
ClosedPublic

Authored by Fabien on Nov 26 2019, 10:04.

Details

Summary

The AssertLockHeld() assumes that cs_main is always locked when
calling GuessVerificationProgress().
However, as stated in the function comment, this might not always be
true as the lock is only required under some circumstances. The
assertion is then too restrictive.
Note that this makes our code in sync with current core codebase.

Test Plan

With debug enabled:

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable