Page MenuHomePhabricator

Remove undue lock assertion in GuessVerificationProgess
ClosedPublic

Authored by Fabien on Tue, Nov 26, 10:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC73363737ff39: Remove undue lock assertion in GuessVerificationProgess
Summary

The AssertLockHeld() assumes that cs_main is always locked when
calling GuessVerificationProgress().
However, as stated in the function comment, this might not always be
true as the lock is only required under some circumstances. The
assertion is then too restrictive.
Note that this makes our code in sync with current core codebase.

Test Plan

With debug enabled:

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Nov 26, 10:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 26, 10:04
deadalnix accepted this revision.Tue, Nov 26, 10:19
This revision is now accepted and ready to land.Tue, Nov 26, 10:19
This revision was automatically updated to reflect the committed changes.