The AssertLockHeld() assumes that cs_main is always locked when
calling GuessVerificationProgress().
However, as stated in the function comment, this might not always be
true as the lock is only required under some circumstances. The
assertion is then too restrictive.
Note that this makes our code in sync with current core codebase.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING73363737ff39: Remove undue lock assertion in GuessVerificationProgess
rABC73363737ff39: Remove undue lock assertion in GuessVerificationProgess
With debug enabled:
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- remove_assert_lock_gvp
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8293 Build 14608: Default Diff Build & Tests Build 14607: arc lint + arc unit