Rename m_is_loaded -> m_load_tried
Summary:
This diff does not change behavior, it just renames functions and improves comments
m_is_loaded/IsLoaded() doesn't actually indicate whether or not the
mempool was successfully, loaded, but rather if a load has been
attempted and did not result in a catastrophic ShutdownRequested.Scripted diff:
-BEGIN VERIFY SCRIPT-
find_regex="\bm_is_loaded\b" \&& git grep -l -E "$find_regex" \ | xargs sed -i -E "s@$find_regex@m_load_tried@g"find_regex="\bIsLoaded\b" \
&& git grep -l -E "$find_regex" \ | xargs sed -i -E "s@$find_regex@GetLoadTried@g"find_regex="\bSetIsLoaded\b" \
&& git grep -l -E "$find_regex" \ | xargs sed -i -E "s@$find_regex@SetLoadTried@g"-END VERIFY SCRIPT-
https://github.com/bitcoin/bitcoin/pull/25487/commits/813962da0b17b918941c6849996845e35d84a451
Improve comments for [GS]etLoadTried
Also change the param name for SetLoadTried to load_tried.
https://github.com/bitcoin/bitcoin/commit/f9e8e5719f28d84f68f7d75e26c8e7fccac8e7d3
This is a partial backport of core#25487
Depends on D15717
Test Plan: ninja all check-all
Reviewers: #bitcoin_abc, Fabien
Reviewed By: #bitcoin_abc, Fabien
Differential Revision: https://reviews.bitcoinabc.org/D15718