HomePhabricator

[validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders()

Description

[validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders()

Summary:
No callers use the returned value in first_invalid. Remove it from the
function signature and don't set it in the function.

Partial backport of Core PR15921 : https://github.com/bitcoin/bitcoin/pull/15921/commits/c428622a5bb1e37b2e6ab2c52791ac05d9271238

Depends on D6873 only to be lint-free.

Test Plan: ninja check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6874

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Apr 28 2019, 20:46
jasonbcoxCommitted on Jul 9 2020, 22:06
jasonbcoxPushed on Jul 9 2020, 22:06
Reviewer
Restricted Project
Differential Revision
D6874: [validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders()
Parents
rABCfeee46d6ef81: [validation] Remove error() calls from Invalid() calls
Branches
Unknown
Tags
Unknown