Paths

Table of Contentst

Differential D6874

[validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders()
ClosedPublic
Actions

Authored by jasonbcox on Jul 9 2020, 16:59.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC754a9d81cf88: [validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders()

Summary

No callers use the returned value in first_invalid. Remove it from the
function signature and don't set it in the function.

Partial backport of Core PR15921 : https://github.com/bitcoin/bitcoin/pull/15921/commits/c428622a5bb1e37b2e6ab2c52791ac05d9271238

Depends on D6873 only to be lint-free.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 9 2020, 16:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2020, 16:59

jasonbcox requested review of this revision.Jul 9 2020, 16:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11928: Diff 22123.Jul 9 2020, 17:18

Fabien accepted this revision.Jul 9 2020, 19:08

This revision is now accepted and ready to land.Jul 9 2020, 19:08

Closed by commit rABC754a9d81cf88: [validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders() (authored by John Newbery <john@johnnewbery.com>, committed by jasonbcox). · Explain WhyJul 9 2020, 22:06

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC754a9d81cf88: [validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders().

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

4 lines

rpc/

mining.cpp

3 lines

test/

blockfilter_index_tests.cpp

3 lines

checkpoints_tests.cpp

22 lines

validation.h

4 lines

validation.cpp

10 lines

Diff 22141

View Options

src/net_processing.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/checkpoints_tests.cpp

View Options

src/validation.h

View Options

[validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22141

src/net_processing.cpp

src/rpc/mining.cpp

src/test/blockfilter_index_tests.cpp

src/test/checkpoints_tests.cpp

src/validation.h

src/validation.cpp

[validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders()
ClosedPublic
Actions

Revision Contents
Changeset List