HomePhabricator

[backport#16624 2/4] Remove SyncTransaction for conflicted txn in CWallet…

Description

[backport#16624 2/4] Remove SyncTransaction for conflicted txn in CWallet::BlockConnected

Summary:
We shouldn't rely on this sync call to get an accurate view of txn
state, if a tx conflicts with one in mapTx we are going to update
our wallet dependencies in AddToWalletIfInvolvingMe while conflicting
txn get connected. If it doesn't conflict with one of our dependencies
we are not going to track it anyway.

This is a cleanup, as this SyncTransaction is redundant with the
following one for confirmation which is triggering the MarkConflicted
logic. We keep the loop because set of conflicted txn isn't same as txn
included in block.

https://github.com/bitcoin/bitcoin/pull/16624/commits/7e89994133725125dddbfa8d45484e3b9ed51c6e


Depends on D7048

Partial backport of Core PR16624

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7049

Details

Provenance
Antoine Riard <ariard@student.42.fr>Authored on Aug 15 2019, 15:42
majcostaCommitted on Jul 28 2020, 11:04
majcostaPushed on Jul 28 2020, 11:04
Reviewer
Restricted Project
Differential Revision
D7049: [backport#16624 2/4] Remove SyncTransaction for conflicted txn in CWallet::BlockConnected
Parents
rABC5e818a52f520: [backport#16624 1/4] Encapsulate tx status in a Confirmation struct
Branches
Unknown
Tags
Unknown