Page MenuHomePhabricator

[backport#16624 2/4] Remove SyncTransaction for conflicted txn in CWallet::BlockConnected
ClosedPublic

Authored by majcosta on Mon, Jul 27, 19:19.

Details

Summary

We shouldn't rely on this sync call to get an accurate view of txn
state, if a tx conflicts with one in mapTx we are going to update
our wallet dependencies in AddToWalletIfInvolvingMe while conflicting
txn get connected. If it doesn't conflict with one of our dependencies
we are not going to track it anyway.

This is a cleanup, as this SyncTransaction is redundant with the
following one for confirmation which is triggering the MarkConflicted
logic. We keep the loop because set of conflicted txn isn't same as txn
included in block.

https://github.com/bitcoin/bitcoin/pull/16624/commits/7e89994133725125dddbfa8d45484e3b9ed51c6e


Depends on D7048

Partial backport of Core PR16624

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Mon, Jul 27, 19:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jul 27, 19:19
teamcity edited the summary of this revision. (Show Details)Mon, Jul 27, 22:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Tue, Jul 28, 09:14
This revision is now accepted and ready to land.Tue, Jul 28, 09:14