HomePhabricator

net: recognize I2P from ParseNetwork() so that -onlynet=i2p works, do not skip…

Description

net: recognize I2P from ParseNetwork() so that -onlynet=i2p works, do not skip I2P in GetNetworkNames()

Summary:

net: recognize I2P from ParseNetwork() so that -onlynet=i2p works

https://github.com/bitcoin/bitcoin/pull/20685/commits/0181e244394bd9e68e9f0d44704e7b0fd12a6b1f

net: Do not skip the I2P network from GetNetworkNames()

So that help texts include "i2p" in:

  • ./bitcoind -help (in -onlynet description)
  • getpeerinfo RPC
  • getnetworkinfo RPC

Co-authored-by: Jon Atack <jon@atack.com>

https://github.com/bitcoin/bitcoin/pull/20685/commits/a701fcf01f3ea9a12e869bfa52321302cf68351c

This concludes backport of core#20685 [19,20/20]
Depends on D11029 and D11036

Test Plan:
ninja all check-all

src/bitcoind -regtest -i2psam=127.0.0.1:7656 -onlynet=i2p -debug=i2p

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11037

Details

Provenance
Vasil Dimov <vd@FreeBSD.org>Authored on Dec 7 2020, 16:24
PiRKCommitted on Feb 15 2022, 18:07
PiRKPushed on Feb 15 2022, 18:07
Reviewer
Restricted Project
Differential Revision
D11037: net: recognize I2P from ParseNetwork() so that -onlynet=i2p works, do not skip I2P in GetNetworkNames()
Parents
rABCe9e01caeb642: net, rpc: return NET_UNROUTABLE as not_publicly_routable, automate helps
Branches
Unknown
Tags
Unknown