Page MenuHomePhabricator
Differential D11037

net: recognize I2P from ParseNetwork() so that -onlynet=i2p works, do not skip I2P in GetNetworkNames()
ClosedPublic
Actions

Authored by PiRK on Feb 10 2022, 15:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC795cafd9a4ea: net: recognize I2P from ParseNetwork() so that -onlynet=i2p works, do not skip…
Summary

net: recognize I2P from ParseNetwork() so that -onlynet=i2p works

https://github.com/bitcoin/bitcoin/pull/20685/commits/0181e244394bd9e68e9f0d44704e7b0fd12a6b1f

net: Do not skip the I2P network from GetNetworkNames()

So that help texts include "i2p" in:

  • ./bitcoind -help (in -onlynet description)
  • getpeerinfo RPC
  • getnetworkinfo RPC

Co-authored-by: Jon Atack <jon@atack.com>

https://github.com/bitcoin/bitcoin/pull/20685/commits/a701fcf01f3ea9a12e869bfa52321302cf68351c

This concludes backport of core#20685 [19,20/20]
Depends on D11029 and D11036

Test Plan

ninja all check-all

src/bitcoind -regtest -i2psam=127.0.0.1:7656 -onlynet=i2p -debug=i2p

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 10 2022, 15:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2022, 15:20
PiRK requested review of this revision.Feb 10 2022, 15:21
teamcity edited the summary of this revision. (Show Details)Feb 10 2022, 15:22
Harbormaster completed remote builds in B18244: Diff 32337.Feb 10 2022, 15:43
PiRK planned changes to this revision.Feb 11 2022, 08:04
PiRK requested review of this revision.Feb 11 2022, 14:44
PiRK edited the test plan for this revision. (Show Details)
PiRK added a child revision: D11041: doc: add basic I2P documentation.Feb 11 2022, 14:52
PiRK added a child revision: D11042: p2p: Refactor sock to add I2P unit test.Feb 11 2022, 14:55
Fabien requested changes to this revision.Feb 14 2022, 09:43
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpc_net.py
145 ↗(On Diff #32337)

Dedup

This revision now requires changes to proceed.Feb 14 2022, 09:43
PiRK updated this revision to Diff 32368.Feb 14 2022, 20:47
PiRK edited the test plan for this revision. (Show Details)

deduplicate comment

Harbormaster completed remote builds in B18266: Diff 32368.Feb 14 2022, 21:07
Fabien accepted this revision.Feb 15 2022, 07:19
This revision is now accepted and ready to land.Feb 15 2022, 07:19
Closed by commit rABC795cafd9a4ea: net: recognize I2P from ParseNetwork() so that -onlynet=i2p works, do not skip… (authored by Vasil Dimov <vd@FreeBSD.org>, committed by PiRK). · Explain WhyFeb 15 2022, 18:12
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC795cafd9a4ea: net: recognize I2P from ParseNetwork() so that -onlynet=i2p works, do not skip….

Revision Contents
Changeset List

PathSize
src/
2 lines
7 lines
test/
functional/
6 lines

Diff 32395

View Options

src/init.cpp

Loading...
View Options

src/netbase.cpp

Loading...
View Options

test/functional/rpc_net.py

Loading...